mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Review Request 51768: Updated signature of `delegate` and `execute` method.
Date Fri, 09 Sep 2016 21:33:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51768/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Qian Zhang.


Bugs: MESOS-6023
    https://issues.apache.org/jira/browse/MESOS-6023


Repository: mesos


Description
-------

In case of `spec::CNI_CMD_DEL` the CNI plugin is not supposed to
return any output. Hence, changing the signatures to return an
`Result` and an `Option` respectively.


Diffs
-----

  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/main.cpp 11c03fdf8a85414d20704299103e22be7d844f80

  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp
85547533b0b13011615b512ec8c71b7545f33324 
  src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp
0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 

Diff: https://reviews.apache.org/r/51768/diff/


Testing
-------

make


Thanks,

Avinash sridharan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message