mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 51420: Added provisioner appc unit test for provisioning nested container.
Date Fri, 09 Sep 2016 20:53:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51420/#review148369
-----------------------------------------------------------




src/tests/containerizer/provisioner_appc_tests.cpp (line 345)
<https://reviews.apache.org/r/51420/#comment215825>

    s/an/a
    s/contaienr/container



src/tests/containerizer/provisioner_appc_tests.cpp (line 395)
<https://reviews.apache.org/r/51420/#comment215827>

    We are testing if the rootfs is provisioned at the correct hierarchy in the sandbox right?
Maybe the comments here should reflect that?


- Avinash sridharan


On Sept. 9, 2016, 8:07 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51420/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6067
>     https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added provisioner appc unit test for provisioning nested container.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp b3ba176e506a6d1528290c07a8a0555b12c8cf70

> 
> Diff: https://reviews.apache.org/r/51420/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message