mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 51402: Added nested container check in provisioner destroy.
Date Fri, 09 Sep 2016 20:43:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51402/#review148367
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 429)
<https://reviews.apache.org/r/51402/#comment215823>

    s/infos/`infos`



src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 437)
<https://reviews.apache.org/r/51402/#comment215824>

    s/is/ has not been


- Avinash sridharan


On Sept. 9, 2016, 8:07 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51402/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6067
>     https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Please see the comments in the patch for detail.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 8e35ff49ec99a242e764095dcfbb541c5e41ec71

> 
> Diff: https://reviews.apache.org/r/51402/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message