mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 50271: Created an isolator for Linux capabilities.
Date Fri, 09 Sep 2016 15:31:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50271/#review148338
-----------------------------------------------------------




src/tests/containerizer/isolator_tests.cpp (lines 1825 - 1826)
<https://reviews.apache.org/r/50271/#comment215808>

    This should be fixed in `createTask` in a separate patch.



src/tests/containerizer/isolator_tests.cpp (lines 1886 - 1891)
<https://reviews.apache.org/r/50271/#comment215811>

    This test case does succeed even though it shouldn't.
    
    The error might be in how we handle capabilities if no task `uid` is given.



src/tests/containerizer/isolator_tests.cpp (lines 1909 - 1915)
<https://reviews.apache.org/r/50271/#comment215810>

    This test case does succeed even though it shouldn't.
    
    The error might be in how we handle capabilities if no task `uid` is given.



src/tests/containerizer/isolator_tests.cpp (lines 1955 - 1960)
<https://reviews.apache.org/r/50271/#comment215809>

    This test case hangs waiting for `status2` where `status1` should already be failed. For
some reason the `Failure` emitted from the isolator's `prepare` doesn't propagate properly.


- Benjamin Bannier


On Sept. 9, 2016, 5:26 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50271/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 5:26 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Jie Yu.
> 
> 
> Bugs: MESOS-5275
>     https://issues.apache.org/jira/browse/MESOS-5275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This isolator evaluates agent allowed capabilities and passes net
> capabilities on to `mesos-containerizer` which enforces the
> capabilities.
> 
> Capability information is passed via a new field in
> `ContainerLaunchInfo`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 16dd3a19145b9764273cdb9a8899e353c98730e5 
>   src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 
>   src/Makefile.am 15b9a63822eca8d0b428191940026756fba7821e 
>   src/slave/containerizer/mesos/containerizer.cpp 89b7e8db38916d69d9b2d4fe305d4397b0859a10

>   src/slave/containerizer/mesos/isolators/linux/capabilities.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/linux/capabilities.cpp PRE-CREATION 
>   src/tests/containerizer/isolator_tests.cpp f8056ca08029feed5f164d4f94e24d521183bdfc

> 
> Diff: https://reviews.apache.org/r/50271/diff/
> 
> 
> Testing
> -------
> 
> `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message