mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51028: Fix tests with rapidly triggered allocations.
Date Fri, 09 Sep 2016 09:20:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51028/#review148318
-----------------------------------------------------------



This patch should actually should goes after /r/51027 , the test cases will not need such
update without /r/51027 , so I think that we propbably need to merge this with /r/51027 ?


src/tests/hierarchical_allocator_tests.cpp (line 3534)
<https://reviews.apache.org/r/51028/#comment215796>

    `allocationRuns` sounds like a better name but this will make the code not cosistent,
what is your concern if we continue using `offerCallbacks` here?


- Guangya Liu


On 九月 8, 2016, 10:12 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51028/
> -----------------------------------------------------------
> 
> (Updated 九月 8, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3157
>     https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Per MESOS-3157, if cluster events with the possibility
>   of triggering an allocation occur rapidly and test
>   assertions depend on gleaning information from assumed
>   order, it is likely they will fail due to lack of parity
>   between event and actual allocation. Ensure that expected
>   allocations occur.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp b2179215f3a4c2f4018670e8e54f02e06c39c3b1

> 
> Diff: https://reviews.apache.org/r/51028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message