mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <>
Subject Re: Review Request 51700: Add `FrameworkAdded` event to master event stream.
Date Fri, 09 Sep 2016 06:46:16 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 9, 2016, 6:46 a.m.)

Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and Vinod Kone.


Clean up unnecessary Slave in the test so future slave related test does not break this.

Bugs: MESOS-6101

Repository: mesos


Changes included:
- Moving `model()` helper function to common/protobuf_utils;
- Definition of event and response;
- Sending event from master;
- new test.

Diffs (updated)

  include/mesos/master/master.proto 1ea79fd7ecd9c2b7e94718fc8c7779d1051583db 
  include/mesos/v1/master/master.proto 58dc65006658f47bb752ee1c0c1520ee3cc03bd7 
  src/common/protobuf_utils.hpp 3324838f0a54491024b3e26ddf38afbfad31b8e4 
  src/common/protobuf_utils.cpp 8c4a7264080385789157703b05b42716fb0563b3 
  src/master/http.cpp 52dd80b856cf2317c0b73ba54bf501696786088d 
  src/master/master.cpp d94a8510c4cee9c010706f79caf27ef4a10b41a8 
  src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb 




Zhitao Li

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message