mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51674: Supported mesos containerizer destroy to be nested aware.
Date Fri, 09 Sep 2016 02:42:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51674/#review148298
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp (line 1669)
<https://reviews.apache.org/r/51674/#comment215779>

    I think you need to put the code below this line into a helper method, and call the helper
method in `await(subContainers).then(helper)`. Otherwise, we will destroy parent container
and its nested containers in parallel.


- Qian Zhang


On Sept. 7, 2016, 5:53 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51674/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 5:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported mesos containerizer destroy to be nested aware.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 89b7e8db38916d69d9b2d4fe305d4397b0859a10

> 
> Diff: https://reviews.apache.org/r/51674/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message