mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 51565: Added a way to set logrotate settings per executor.
Date Thu, 08 Sep 2016 20:57:53 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 8, 2016, 1:57 p.m.)

Review request for mesos, Benjamin Mahler, Cody Maloney, Artem Harutyunyan, and Vinod Kone.


Rename a local variable.

Repository: mesos


The provided `LogrotateContainerLogger` did not have enough granularity
when setting log rotation settings.  This patch adds a way for each
executor to set its own log rotation settings, using the global values
as defaults.

The executor settings are provided via environment variables in the

Diffs (updated)

  docs/ 3b36870c22336440b0d7bf1359e1d0a97986a0f6 
  src/slave/container_loggers/lib_logrotate.hpp f216548ef37f5c2245ef64d21e84e06100e8e5ae 
  src/slave/container_loggers/lib_logrotate.cpp 01552752a56ee7377a631a783f2168ba0eea2799 
  src/tests/container_logger_tests.cpp e8f934106510fe02b8b92be19c918a1e5c0b78fd 



Previewed documentation change via the website previewer.

make check


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message