mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Review Request 51720: Updated tests to properly set 'flags.launcher' with correct value.
Date Thu, 08 Sep 2016 10:09:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51720/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-6141
    https://issues.apache.org/jira/browse/MESOS-6141


Repository: mesos


Description
-------

In some of our tests we manually create a 'PosixLauncher' rather than
relying on the value of 'flags.launcher' to decide which type of
launcher to create. Since calls to 'CreateSlaveFlags()' set
'flags.launcher' to 'linux' by default, there was a discrepency in
what the flags said, and what actual launcher type we were creating.

This commit fixes this to explicitly set 'flags.launcher' to the
appropriate type.


Diffs
-----

  src/tests/container_logger_tests.cpp e8f934106510fe02b8b92be19c918a1e5c0b78fd 
  src/tests/containerizer/isolator_tests.cpp f8056ca08029feed5f164d4f94e24d521183bdfc 
  src/tests/containerizer/mesos_containerizer_tests.cpp 72346c748598e4c0787dba09d9ccb59f244b0df5


Diff: https://reviews.apache.org/r/51720/diff/


Testing
-------

make check


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message