mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 51710: Minor fix to avoid creating an unnecessary temporary when looping.
Date Thu, 08 Sep 2016 09:45:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51710/#review148166
-----------------------------------------------------------



Reading the summary I am confused what the purpose of this patch is. Is this about harmonizing
the style of the iteration here? The current summary reads like this patch somehow optimizes,
while in fact it removes explicit caching and replaces it with potentially repeated recomputations
(which _might_ be optimized out for certain compiler settings).

- Benjamin Bannier


On Sept. 8, 2016, 7:45 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51710/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 7:45 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Minor fix to avoid creating an unnecessary temporary when looping.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 2da5a2986c427250664b2bf3456039f86e5c6079 
> 
> Diff: https://reviews.apache.org/r/51710/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message