mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 50271: Created an isolator for Linux capabilities.
Date Thu, 08 Sep 2016 05:59:25 GMT


> On Sept. 6, 2016, 9 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/capabilities.hpp, line 41
> > <https://reviews.apache.org/r/50271/diff/6/?file=1491905#file1491905line41>
> >
> >     are we consistent on 'override' keyword? I'd suggest we be consistent with other
isolators for now.

We consistently do not use `override`. I changed this code to explicitly be `virtual` as documentation.


> On Sept. 6, 2016, 9 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/capabilities.cpp, lines 45-56
> > <https://reviews.apache.org/r/50271/diff/6/?file=1491906#file1491906line45>
> >
> >     This looks unreadable to me. Can you use if/else instead?

Done.


> On Sept. 6, 2016, 9 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/capabilities.cpp, line 46
> > <https://reviews.apache.org/r/50271/diff/6/?file=1491906#file1491906line46>
> >
> >     I think we should use containerConfig.container_info now as we plan to supported
nested container.

Done.


> On Sept. 6, 2016, 9 p.m., Jie Yu wrote:
> > include/mesos/slave/containerizer.proto, line 144
> > <https://reviews.apache.org/r/50271/diff/6/?file=1491901#file1491901line144>
> >
> >     the two sentenses here look a little duplicate?

I meant them to be orthogonal. Could you suggest a better alternative?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50271/#review147886
-----------------------------------------------------------


On Sept. 7, 2016, 6:46 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50271/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 6:46 p.m.)
> 
> 
> Review request for mesos, Jay Guo and Jie Yu.
> 
> 
> Bugs: MESOS-5275
>     https://issues.apache.org/jira/browse/MESOS-5275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This isolator evaluates agent allowed capabilities and passes net
> capabilities on to `mesos-containerizer` which enforces the
> capabilities.
> 
> Capability information is passed via a new field in
> `ContainerLaunchInfo`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 16dd3a19145b9764273cdb9a8899e353c98730e5 
>   src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 
>   src/Makefile.am 15b9a63822eca8d0b428191940026756fba7821e 
>   src/slave/containerizer/mesos/containerizer.cpp 89b7e8db38916d69d9b2d4fe305d4397b0859a10

>   src/slave/containerizer/mesos/isolators/linux/capabilities.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/linux/capabilities.cpp PRE-CREATION 
>   src/tests/containerizer/isolator_tests.cpp f8056ca08029feed5f164d4f94e24d521183bdfc

> 
> Diff: https://reviews.apache.org/r/50271/diff/
> 
> 
> Testing
> -------
> 
> `make check` and `sudo make check` (Debian jessie, gcc-4.9.2, w/o optimizations)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message