mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 51027: Track allocation candidates to bound allocator.
Date Thu, 08 Sep 2016 04:35:27 GMT


> On Sept. 3, 2016, 6:38 a.m., Guangya Liu wrote:
> > src/master/allocator/mesos/hierarchical.cpp, lines 1226-1229
> > <https://reviews.apache.org/r/51027/diff/4/?file=1490734#file1490734line1226>
> >
> >     Just nit, I think that we should separate the `_allocate()` and `_deallocate()`
to use different time elapse. But as the original logic is also putting the `_deallocate()`
logic in `_allocate()`, so I think that it is OK to keep such logic but may need an update
if we want to make the time more accurate for diffrent actions: `_allocate()` and `_deallocate()`.
> >     
> >     ```
> >     stopwatch.start();
> >     
> >     metrics.allocation_run.start();
> >     
> >     _allocate();
> >     
> >     metrics.allocation_run.stop();
> >     
> >     stopwatch.stop();
> >     
> >     VLOG(1) << "Performed allocation for " << allocationCandidates.size()
> >             << " agents in " << stopwatch.elapsed();
> >             
> >     stopwatch.start();
> >     
> >     _deallocate();
> >     
> >     stopwatch.stop();
> >     
> >     VLOG(1) << "Performed deallocation for " << allocationCandidates.size()
> >             << " agents in " << stopwatch.elapsed();
> >     ```

Yea, I think preserving the original behavior was the idea here so the metrics reflect that.


- Jacob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51027/#review147718
-----------------------------------------------------------


On Sept. 3, 2016, 6:05 a.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51027/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2016, 6:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, James Peach, Klaus Ma, and Jiang
Yan Xu.
> 
> 
> Bugs: MESOS-3157
>     https://issues.apache.org/jira/browse/MESOS-3157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Triggered allocations dispatch allocate() only
>   if there is no pending allocation in the queue.
> - Allocation candidates are accumulated and only
>   cleared when enqueued allocations are processed.
> - Batched allocations are handled synchronously.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp dd07ed221d2c1755d2478369641ffdc46ecc4471

>   src/master/allocator/mesos/hierarchical.cpp 9e5db2196c6a541dc1208ba8b9f13ef9a518bcc4

> 
> Diff: https://reviews.apache.org/r/51027/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> note: check without filters depends on https://reviews.apache.org/r/51028
> 
> With new benchmark https://reviews.apache.org/r/49617: 
> Sample output without 51027:
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
> Using 10000 agents and 3000 frameworks
> Added 3000 frameworks in 57251us
> Added 10000 agents in 3.21345353333333mins
> allocator settled after  1.61236038333333mins
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
(290578 ms)
> 
> Sample output with 51027:
> [ RUN      ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
> Using 10000 agents and 3000 frameworks
> Added 3000 frameworks in 39817us
> Added 10000 agents in 3.22860541666667mins
> allocator settled after  25.525654secs
> [       OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.FrameworkFailover/22
(220137 ms)
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message