mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.
Date Thu, 08 Sep 2016 02:17:35 GMT


> On 九月 7, 2016, 10:17 a.m., Guangya Liu wrote:
> > src/slave/slave.hpp, line 1027
> > <https://reviews.apache.org/r/51477/diff/3/?file=1492260#file1492260line1027>
> >
> >     How about const?
> 
> Anand Mazumdar wrote:
>     Can you elaborate? Non member functions can't be marked `const`. Also, did you mean
`const` on the return type?

Sorry for confuse, yes, what about the return type as const?


> On 九月 7, 2016, 10:17 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 1711
> > <https://reviews.apache.org/r/51477/diff/3/?file=1492261#file1492261line1711>
> >
> >     s/for/to
> 
> Anand Mazumdar wrote:
>     Why? This looks fine to me.

I do not have strong intention for this, just depend on you, but seems we use `send .... to
...` more frequently ;-)


> On 九月 7, 2016, 10:17 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 1748
> > <https://reviews.apache.org/r/51477/diff/3/?file=1492261#file1492261line1748>
> >
> >     What about enhance the reason as `Task killed before it was launched due to
one task killed in the task group`?
> 
> Anand Mazumdar wrote:
>     We haven't been doing such fine grained error messaging on the Master too. We might
consider doing it in the future. I would file a JIRA for posterity.

Sounds good, thanks Anand.


> On 九月 7, 2016, 10:17 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, lines 1988-1989
> > <https://reviews.apache.org/r/51477/diff/3/?file=1492261#file1492261line1988>
> >
> >     What about adding `executor state` to the log message?
> 
> Anand Mazumdar wrote:
>     Why? Also, we weren't logging the state before either.

We actually have the executor state in log message but not here, please refer to https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1824

Another point is that this is a new message that you introduced, and the log message for `Executor::REGISTERING`
and `Executor::RUNNING` are same, it is better distinguish those log messages by adding the
executor state here for debugability.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51477/#review147994
-----------------------------------------------------------


On 九月 7, 2016, 10:13 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51477/
> -----------------------------------------------------------
> 
> (Updated 九月 7, 2016, 10:13 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
>     https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes implements the `runTaskGroup()` handler on the
> agent ensuring that task group is sent atomically to the executor
> via the `LAUNCH_GROUP` event. It also refactors `runTask()`/`_runTask()`
> to go through a common handler function. Also, it ensures that all
> tasks in `framework->pending`/`queuedTasks` that are killed before
> running the task group result in all the tasks being killed.
> 
> Review: https://reviews.apache.org/r/51477/
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 
>   src/slave/slave.cpp 11664779ed78c0a5913598bb7dd1bb0e793d6b93 
> 
> Diff: https://reviews.apache.org/r/51477/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message