mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 51480: Added tests for launching task groups on the agent.
Date Wed, 07 Sep 2016 22:12:04 GMT


> On Sept. 7, 2016, 5:37 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, lines 4621-4622
> > <https://reviews.apache.org/r/51480/diff/2/?file=1492271#file1492271line4621>
> >
> >     why did you need to explicitly do this here but not in the above test?

In the previous test we did not use the `MockSlave` directly but just used the `StartSlave()`
helper. Hence, it was not needed.


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review148037
-----------------------------------------------------------


On Sept. 6, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
>     https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> Review: https://reviews.apache.org/r/51480/
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message