mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 45966: Offer shared resources to frameworks only if opted in.
Date Wed, 07 Sep 2016 22:09:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45966/#review148098
-----------------------------------------------------------


Fix it, then Ship it!




Can we have a simple allocator test with two frameworks, one framework without the capability
doesn't get allocated the shared resource and the other with the capability gets it?

Could be in a follow up review.


src/examples/persistent_shared_volume_framework.cpp (lines 579 - 580)
<https://reviews.apache.org/r/45966/#comment215527>

    Take this out for now and add it later together?


- Jiang Yan Xu


On Sept. 7, 2016, 10:57 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45966/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 10:57 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4325
>     https://issues.apache.org/jira/browse/MESOS-4325
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new capability SHARED_RESOURCES that frameworks need to opt
> in if they are interested in receiving shared resources in their
> offers.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 7fbcdf005718ba4d7ec3b02cf70a3fc53d4f4818 
>   include/mesos/v1/mesos.proto 60ec0cce35e5e2d2f4907efadc7ab92680566ef0 
>   src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
>   src/master/allocator/mesos/hierarchical.hpp dd07ed221d2c1755d2478369641ffdc46ecc4471

>   src/master/allocator/mesos/hierarchical.cpp 9e5db2196c6a541dc1208ba8b9f13ef9a518bcc4

>   src/tests/hierarchical_allocator_tests.cpp 24698ffc9f72bc1e144e5107412f5e7d9c4f7105

> 
> Diff: https://reviews.apache.org/r/45966/diff/
> 
> 
> Testing
> -------
> 
> Tests updated with new capability.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message