mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 51402: Added nested container check in provisioner destroy.
Date Wed, 07 Sep 2016 18:50:25 GMT


> On Sept. 5, 2016, 7:38 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/provisioner/provisioner.cpp, lines 432-434
> > <https://reviews.apache.org/r/51402/diff/2/?file=1488230#file1488230line432>
> >
> >     Just a question, how do we ensure when a container is being destroyed, all its
sub-containers are already destroyed? Will we need to add some logic in the caller of provisioner
destroy to ensure this?

This is ensured in containerizer::destroy().


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51402/#review147760
-----------------------------------------------------------


On Sept. 7, 2016, 11:49 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51402/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6067
>     https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added nested container check in provisioner destroy.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 8e35ff49ec99a242e764095dcfbb541c5e41ec71

> 
> Diff: https://reviews.apache.org/r/51402/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message