mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 51392: Supported provisioner listContainers() to be recursive.
Date Wed, 07 Sep 2016 18:49:34 GMT


> On Aug. 30, 2016, 3:56 p.m., Joseph Wu wrote:
> > src/slave/containerizer/mesos/provisioner/paths.cpp, lines 194-196
> > <https://reviews.apache.org/r/51392/diff/2/?file=1488228#file1488228line194>
> >
> >     You don't really need to check if the subcontainers are empty here.

Fixed.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51392/#review147380
-----------------------------------------------------------


On Sept. 7, 2016, 11:49 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51392/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 11:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6067
>     https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch supports collecting all containerIds (all containers in the
> nested hierarchy) recursively.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/paths.cpp 86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb

> 
> Diff: https://reviews.apache.org/r/51392/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message