mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 46220: Added documentation for Nvidia GPU support.
Date Wed, 07 Sep 2016 17:52:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46220/#review148043
-----------------------------------------------------------


Fix it, then Ship it!




This is great! Thanks for being so thorough.


docs/gpu-support.md (line 125)
<https://reviews.apache.org/r/46220/#comment215415>

    traditional



docs/gpu-support.md (line 286)
<https://reviews.apache.org/r/46220/#comment215419>

    "set LD_LIBRRARY_PATH to `lib`" or "add `lib` to LD_LIBRRARY_PATH"?



docs/gpu-support.md (line 333)
<https://reviews.apache.org/r/46220/#comment215421>

    s/unit/Mesos unit/



docs/gpu-support.md (line 360)
<https://reviews.apache.org/r/46220/#comment215422>

    binary



docs/gpu-support.md (lines 366 - 367)
<https://reviews.apache.org/r/46220/#comment215424>

    you can combine these 2 into one
    
    ```
    $ make -j check GTEST_FILTER="*NVIDIA_GPU*"
    ```


- Vinod Kone


On Sept. 7, 2016, 11:19 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46220/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 11:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-5221
>     https://issues.apache.org/jira/browse/MESOS-5221
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added documentation for Nvidia GPU support.
> 
> 
> Diffs
> -----
> 
>   docs/gpu-support.md PRE-CREATION 
>   docs/home.md c8aeaef1d7e2bc6fc51e7bafaa9ff66aa376c0bc 
> 
> Diff: https://reviews.apache.org/r/46220/diff/
> 
> 
> Testing
> -------
> 
> Ran a local copy of the documentation site to make sure everything looks OK.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message