mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51480: Added tests for launching task groups on the agent.
Date Wed, 07 Sep 2016 14:24:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51480/#review147986
-----------------------------------------------------------




src/tests/slave_tests.cpp (lines 4534 - 4536)
<https://reviews.apache.org/r/51480/#comment215304>

    ```
    // Skip what `Slave::_run()` normally does, save its arguments for
    // later, till reaching the critical moment when to kill the task
    // in the future.
    ```



src/tests/slave_tests.cpp (line 4600)
<https://reviews.apache.org/r/51480/#comment215369>

    s/taskgroup/task group



src/tests/slave_tests.cpp (line 4608)
<https://reviews.apache.org/r/51480/#comment215305>

    4 spaces


- Guangya Liu


On 九月 6, 2016, 9:36 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51480/
> -----------------------------------------------------------
> 
> (Updated 九月 6, 2016, 9:36 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
>     https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds tests for testing the `runTaskGroup()` handler
> on the agent.
> 
> Review: https://reviews.apache.org/r/51480/
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51480/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message