mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint.
Date Wed, 07 Sep 2016 13:54:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46980/#review148009
-----------------------------------------------------------



Bad patch!

Reviews applied: [46980, 46979]

Failed command: ./support/apply-review.sh -n -r 46979

Error:
2016-09-07 13:53:32 URL:https://reviews.apache.org/r/46979/diff/raw/ [4349/4349] -> "46979.patch"
[1]
error: patch failed: src/slave/containerizer/mesos/isolators/network/cni/cni.hpp:120
error: src/slave/containerizer/mesos/isolators/network/cni/cni.hpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15145/console

- Mesos ReviewBot


On May 5, 2016, 2:44 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46980/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5310
>     https://issues.apache.org/jira/browse/MESOS-5310
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented adding a cni network config via 'cni/config' endpoint.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp a06bb89a7a79a62949a48274df806f9f95da09e7

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp dae369aadb940150aa806b28d9269e3d88cf57ed

> 
> Diff: https://reviews.apache.org/r/46980/diff/
> 
> 
> Testing
> -------
> 
> Used `curl` to add a new CNI network configuration via 'cni/config' endpoint, and then
used `mesos-execute` to launch a container to join the newly added CNI network successfully.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message