mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51478: Modified tests to account for `_runTask()` rename.
Date Wed, 07 Sep 2016 13:44:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51478/#review147987
-----------------------------------------------------------




src/tests/master_slave_reconciliation_tests.cpp (line 429)
<https://reviews.apache.org/r/51478/#comment215306>

    s/_run/`_run` ?
    
    I saw that many comments including some functions are not wrapped by ``, so seems need
another patch to update this part.



src/tests/mesos.cpp (line 584)
<https://reviews.apache.org/r/51478/#comment215307>

    4 spaces


- Guangya Liu


On 九月 6, 2016, 9:27 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51478/
> -----------------------------------------------------------
> 
> (Updated 九月 6, 2016, 9:27 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
>     https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change modified the agent mocks/tests to account for the
> `runTask()` rename.
> 
> Review: https://reviews.apache.org/r/51478/
> 
> 
> Diffs
> -----
> 
>   src/tests/master_slave_reconciliation_tests.cpp 7dda6f67d9d02d14759563ec64269060dc7e643b

>   src/tests/mesos.hpp 4cae54b4df906d4b7e8fe8d40d5b0ad59d260e6f 
>   src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 
>   src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 
> 
> Diff: https://reviews.apache.org/r/51478/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message