mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51631: Tracked recovered and prepared cgroups subsystems for containers.
Date Wed, 07 Sep 2016 06:08:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51631/#review147977
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
<https://reviews.apache.org/r/51631/#comment215289>

    After moved these code, I think we may not need this method `CgroupsIsolatorProcess::____recover()`
at all. We can just move the left code of this method into a lambda method, and let `CgroupsIsolatorProcess::___recover()`
call that lambda method, just like what we did for `usage()` and `status()`.


- Qian Zhang


On Sept. 6, 2016, 12:06 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51631/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 12:06 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6063
>     https://issues.apache.org/jira/browse/MESOS-6063
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recover newly added cgroups subsystems on existing containers would
> fail, and continue to perform the `update` and other operations of
> the newly added subsystems on them don't make sense. This patch add
> the tracking for the recovered or prepared cgroups subsystems of a
> container and skip performing unnecessary subsystem operations on the
> container if the subsystem is never recovered or prepared.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 38d1428f5425566502747d2a8394e246e0b3fd9e

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8bab3f15d10c49f223a09eecd5f15e6a13bdac88

> 
> Diff: https://reviews.apache.org/r/51631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message