mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.
Date Wed, 07 Sep 2016 01:32:04 GMT


> On Sept. 1, 2016, 1:48 p.m., Qian Zhang wrote:
> > src/slave/slave.cpp, line 2542
> > <https://reviews.apache.org/r/51477/diff/2/?file=1487469#file1487469line2542>
> >
> >     Here we send a `KillTaskMessage` to executor, but the task to be killed may
be part of a task group, so that means it is executor's responsibility to kill the tasks in
the whole group, right? What if executor does not do it? Will we enforce it in agent?
> 
> Anand Mazumdar wrote:
>     We have never enforced this on the agent (historically for the single task case too)

OK, so that means here the expectation is the executor should cooperate: once the executor
receive a `Kill` event for a task which is part of a task group, it is the executor's responsibility
to kill all the tasks in that group, right?


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51477/#review147401
-----------------------------------------------------------


On Sept. 7, 2016, 5:25 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51477/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6076
>     https://issues.apache.org/jira/browse/MESOS-6076
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This changes implements the `runTaskGroup()` handler on the
> agent ensuring that task group is sent atomically to the executor
> via the `LAUNCH_GROUP` event. It also refactors `runTask()`/`_runTask()`
> to go through a common handler function. Also, it ensures that all
> tasks in `framework->pending`/`queuedTasks` that are killed before
> running the task group result in all the tasks being killed.
> 
> Review: https://reviews.apache.org/r/51477/
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 
>   src/slave/slave.cpp 11664779ed78c0a5913598bb7dd1bb0e793d6b93 
> 
> Diff: https://reviews.apache.org/r/51477/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message