mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51670: Changed the containerizer launch interface for sub-container.
Date Tue, 06 Sep 2016 23:24:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51670/#review147944
-----------------------------------------------------------




src/slave/containerizer/containerizer.hpp (lines 96 - 97)
<https://reviews.apache.org/r/51670/#comment215252>

    well, the slaveId here is not for checkpointing. Fetcher needs slaveId (which is weird).
we should remove slaveId once fetcher does not rely on slaveId.



src/slave/containerizer/containerizer.hpp (lines 101 - 103)
<https://reviews.apache.org/r/51670/#comment215251>

    I'd move those parameters to the end of the argument list.


- Jie Yu


On Sept. 6, 2016, 9:53 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51670/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed the containerizer launch interface for sub-container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/containerizer.hpp f13669d0dfc4ce3287cfe630cabd0470dc765b51

>   src/slave/containerizer/mesos/containerizer.hpp 078ef4f4e7bf5e1522804a720c51cfa5518d8efd

>   src/slave/containerizer/mesos/containerizer.cpp 89b7e8db38916d69d9b2d4fe305d4397b0859a10

> 
> Diff: https://reviews.apache.org/r/51670/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message