mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 45964: Add unit tests for sharing of resources.
Date Tue, 06 Sep 2016 21:48:17 GMT


> On Sept. 1, 2016, 7:30 p.m., Jiang Yan Xu wrote:
> > Moved over some tests to their corresponding changes:
> > 
> > https://github.com/apache/mesos/commit/d4970b78313943aecff7d0366621fbab43563c84
> > https://github.com/apache/mesos/commit/1d5ea3d48e95a10ba6064d9560718f75d14447fc
> > 
> > Moved in tests from https://reviews.apache.org/r/45961/

The changes LGTM.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45964/#review147500
-----------------------------------------------------------


On Sept. 6, 2016, 6:13 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45964/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4324
>     https://issues.apache.org/jira/browse/MESOS-4324
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add unit tests for sharing of resources.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp d960b7575ed5531753e9329e5774b6909090edf8

>   src/tests/master_validation_tests.cpp d40b392f226459d7a21774b0aa066191a9fc95b1 
>   src/tests/mesos.hpp 4cae54b4df906d4b7e8fe8d40d5b0ad59d260e6f 
>   src/tests/persistent_volume_tests.cpp a6f97c4bb5fb29d610c01255036095e2b30c44c5 
>   src/tests/sorter_tests.cpp 821e30d6574b045d25d4de4f7c3b8ac5346d3002 
> 
> Diff: https://reviews.apache.org/r/45964/diff/
> 
> 
> Testing
> -------
> 
> Tests for shared resources added for allocator, resources and sorter.
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message