mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 51477: Implemented `RunTaskGroupMessage` handler on the agent.
Date Tue, 06 Sep 2016 21:25:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51477/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 9:25 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Review comments


Bugs: MESOS-6076
    https://issues.apache.org/jira/browse/MESOS-6076


Repository: mesos


Description (updated)
-------

This changes implements the `runTaskGroup()` handler on the
agent ensuring that task group is sent atomically to the executor
via the `LAUNCH_GROUP` event. It also refactors `runTask()`/`_runTask()`
to go through a common handler function. Also, it ensures that all
tasks in `framework->pending`/`queuedTasks` that are killed before
running the task group result in all the tasks being killed.

Review: https://reviews.apache.org/r/51477/


Diffs (updated)
-----

  src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 
  src/slave/slave.cpp 11664779ed78c0a5913598bb7dd1bb0e793d6b93 

Diff: https://reviews.apache.org/r/51477/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message