mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51654: Fixed help display for containerizer subcommands.
Date Tue, 06 Sep 2016 20:34:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51654/#review147913
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51654]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 6, 2016, 3:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51654/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In this patch we add help displays for all current containerizer
> subcommands. We also trim existing display of the usage; here we use
> that `Flags::usage` already takes care of providing a header.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp d17a45fe17bb74cbf9ae421dc8a492e5dc5f1a00

>   src/slave/containerizer/mesos/launch.cpp 13b65d82e029650e150eb2bc3647d95af167bd72 
>   src/slave/containerizer/mesos/mount.cpp dbd7853a43ee1402f2f91d933a657010efdd76b0 
> 
> Diff: https://reviews.apache.org/r/51654/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Confirmed by explicitly invoking
> 
>     $ mesos-containerizer launch
>     $ mesos-containerizer mount
>     $ mesos-containerizer network-cni-setup
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message