mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <avin...@mesosphere.io>
Subject Re: Review Request 51605: Added "mesos-tcp-connect" binary.
Date Tue, 06 Sep 2016 18:34:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51605/#review147880
-----------------------------------------------------------




src/health-check/tcp_connect.cpp (line 74)
<https://reviews.apache.org/r/51605/#comment215164>

    Why tcpThreeway? we are not testing the TCP threeway handshake (implicitly we are, but
still). Maybe `testTCPConnect`?



src/health-check/tcp_connect.cpp (line 82)
<https://reviews.apache.org/r/51605/#comment215162>

    I think need to handle the 0 and -1 cases separately? 0 represents an invalid string while
-1 represents an invalid address. strerror(errorno) will probably printout SUCCESS for erorrorno=0?or
might be undefined if errorno is not set.


- Avinash sridharan


On Sept. 2, 2016, 4:42 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51605/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 4:42 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, and haosdent
huang.
> 
> 
> Bugs: MESOS-6119
>     https://issues.apache.org/jira/browse/MESOS-6119
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To remove dependency on `bash` for TCP health checks, introduce
> a separate light-weight binary (without libmesos dependency) for
> probing TCP connections.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt b14132abf49a73defd3e4774330b5227726b9207 
>   src/Makefile.am 96edf5b8a4135355ee412e5837e86165885975f8 
>   src/health-check/CMakeLists.txt PRE-CREATION 
>   src/health-check/tcp_connect.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51605/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/51607/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message