mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <>
Subject Re: Review Request 51374: Change registry update order on removal, mark-unreachable.
Date Tue, 06 Sep 2016 15:09:25 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 6, 2016, 3:09 p.m.)

Review request for mesos and Vinod Kone.


Rebase, code cleanup.

Bugs: MESOS-4049 and MESOS-6090

Repository: mesos


This commit changes the master so that we always update the registry
for an important change (e.g., removing an agent or marking an agent
unreachable), before updating the important parts of the master's
in-memory state (e.g., the in-memory list of registered agents).
Previously, the registry was updated first for registration and
reregistration, but second for removal and marking unreachable.
Updating the registry first is simpler, and also avoids possibly
leaking inaccurate information (e.g., via HTTP endpoints) if the
registry operation fails.

Diffs (updated)

  src/master/master.hpp c32c7e9d859ef73216354e2c03ecc07d0009b12f 
  src/master/master.cpp b2a19a645528e8fc1fd48f5ac9929d38c9a76b49 
  src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86 
  src/tests/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00 
  src/tests/slave_tests.cpp 701fab20091f9f7df020290b9f0a9db1dec92647 



make check


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message