mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 50707: Added test for agent removal behavior.
Date Tue, 06 Sep 2016 14:36:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50707/#review147836
-----------------------------------------------------------




src/tests/slave_tests.cpp (line 2810)
<https://reviews.apache.org/r/50707/#comment215118>

    indentation.



src/tests/slave_tests.cpp (line 2890)
<https://reviews.apache.org/r/50707/#comment215119>

    `UnregisterSlaveMessage`



src/tests/slave_tests.cpp (line 2904)
<https://reviews.apache.org/r/50707/#comment215120>

    `UnregisterSlaveMessage`



src/tests/slave_tests.cpp (line 2905)
<https://reviews.apache.org/r/50707/#comment215121>

    `SlaveObserver`



src/tests/slave_tests.cpp (line 2907)
<https://reviews.apache.org/r/50707/#comment215123>

    I think pausing the rate limiter here is a bit confusing because you are essentially stopping
`SlaveObserver::markUnreachable` from being processed.
    
    Instead I would suggest to not use a mock limiter, but just drop the `Master::_markUnreachable`
dispatch before you induced unregistration. You would still need to spoof the dispatch but
I think that is closer to the race.


- Vinod Kone


On Aug. 25, 2016, 2:30 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50707/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 2:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4049
>     https://issues.apache.org/jira/browse/MESOS-4049
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test tries to simulate a race between marking an agent unhealthy
> and receiving an `UnregisterSlaveMessage` for that agent.
> 
> Unfortunately, this test is a little fragile (we need to manually
> dispatch an event to the master process to simulate the action that
> would be taken by the slave observer).
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 84ee37cae97004914b3f0a060dc854e531737dce 
> 
> Diff: https://reviews.apache.org/r/50707/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message