mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 51651: Updated sorting in 'MountInfoTable::read()' to use iterative algorithm.
Date Tue, 06 Sep 2016 14:18:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51651/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 2:18 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Joseph Wu.


Changes
-------

Updated testing summary to indicate CI passing.


Bugs: MESOS-6100 and MESOS-6118
    https://issues.apache.org/jira/browse/MESOS-6100
    https://issues.apache.org/jira/browse/MESOS-6118


Repository: mesos


Description
-------

Previously, we were using a recursive lambda with captured state
as part of the algorithm for sorting the entries in the mount info
table. In certain edge cases, it appeared that doing things this way
may have caused memory corruption that was difficult to reason about.

To avoid this, we have changed the recursive algorithm to an iterative
one. As a side effect, the actual ordering of the entries is now
different with the new algorithm (the original algorithm did a
depth-first traversal of the mount hierarchy and the new one does a
breadth-first traversal).  However, both algorithms maintain the same
invariant -- all parent mount points appear earlier in the sorted list
than their children.


Diffs
-----

  src/linux/fs.cpp 14ae5a9089916549f691363bc2269e13c5260a14 

Diff: https://reviews.apache.org/r/51651/diff/


Testing (updated)
-------

`GTEST_FILTER="*MountInfoTableReadSorted*" make -j24 check`

Everything looks as expected according to the Mesosphere CI.
15x :smile: - 2x :expressionless: - 2x :disappointed:


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message