mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 51031: Added non-recursive version of `cgroups::get`.
Date Mon, 05 Sep 2016 16:01:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51031/
-----------------------------------------------------------

(Updated Sept. 5, 2016, 4:01 p.m.)


Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.


Changes
-------

Rebase.


Bugs: MESOS-6035
    https://issues.apache.org/jira/browse/MESOS-6035


Repository: mesos


Description
-------

In most cases, we just want to get the children cgroups instead of
retrieve descendant cgroups recursively. We added an argument to
`cgroups::get` to indicate whether retrieve cgroups recursively and
make non-recursive retrieve become the default behaviour. This patch
fixed some incorrect `TEST_CGROUPS_ROOT` checks as well.


Diffs (updated)
-----

  src/linux/cgroups.hpp 047d3ea596660e704447c0f0c7b914a43c4a2187 
  src/linux/cgroups.cpp f3232c009d04bb82701c0407b12abf999ab60a73 
  src/tests/containerizer/cgroups_tests.cpp 821c7860ab424bcfadbf597902e046bce9ba3044 
  src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 

Diff: https://reviews.apache.org/r/51031/diff/


Testing
-------


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message