mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51627: Performed systemd::exist() check if systemd support is enabled.
Date Sun, 04 Sep 2016 20:39:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51627/#review147747
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51627]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 4, 2016, 7:11 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51627/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-6122
>     https://issues.apache.org/jira/browse/MESOS-6122
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The flags should come first before the systemd::exists() check
> runs.Currently the systemd.exists() always runs and there's no way to
> disable that check from running in mesos-slave.
> 
> 
> Diffs
> -----
> 
>   src/slave/main.cpp 8c9d241890ffa85f88096385e07789e6fc945ddb 
> 
> Diff: https://reviews.apache.org/r/51627/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message