mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Dasgupta <a10gu...@linux.vnet.ibm.com>
Subject Review Request 51623: Updated mesos-execute to support task groups.
Date Sat, 03 Sep 2016 20:36:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51623/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-6096
    https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description
-------

sThis patch updates mesos-execute to use LAUNCH_GROUP
for launching task groups. I made some assumption
in this patch, like newly introduced `--commands`
option in mesos-execute takes semicolon dimilited values
which will certainly not be the case in final solution. I
am open to suggestion what can we use as delimitter for
`--commands`. In this patch, I kept old `--command` option
as well and it is working as expected. Though new
`--commands` should be able to launch single as well
as multiple tasks and I hope in future we will stick
to one `commands` option.

Suggestions are very welcome for further improvement.


Diffs
-----

  src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 

Diff: https://reviews.apache.org/r/51623/diff/


Testing
-------

On Ubuntu 16.04:
sudo make -j4

and manually ran these commands:
**Successful**
mesos-execute --master=127.0.0.1:5050 --name="LetsCitar" --containerizer=docker --docker_image="ubuntu"
--command="echo hello"

**Stuck after submitting task to agent as agent code for LAUNCH_GROUP is not yet completed**
mesos-execute --master=127.0.0.1:5050 --name="LetsCitar" --containerizer=docker --docker_image="ubuntu"
--commands="echo hello"


Thanks,

Abhishek Dasgupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message