mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 51620: Removed two std::move in MountInfoTable::read.
Date Sat, 03 Sep 2016 00:25:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51620/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-6118
    https://issues.apache.org/jira/browse/MESOS-6118


Repository: mesos


Description
-------

Since 'entry' is a const reference, the std::move won't reduce the
extra copying. This patch removed this optimization.


Diffs
-----

  src/linux/fs.cpp 14ae5a9089916549f691363bc2269e13c5260a14 

Diff: https://reviews.apache.org/r/51620/diff/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message