mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51603: Fixed remaining quoting issues.
Date Fri, 02 Sep 2016 16:17:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51603/#review147670
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51603]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 2, 2016, 3:17 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51603/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 3:17 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4907
>     https://issues.apache.org/jira/browse/MESOS-4907
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `CONFIGURE_FLAGS` might be multiple arguments so a passed string
> should always be exploded when used. Conversely, `SRCDIR` can only be
> used as a single argument; we do know that it does not contain spaces,
> but should quote it nevertheless for consistency.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy/entrypoint.sh 78198d900556427091ab08f25b6df4fc9428dd93 
> 
> Diff: https://reviews.apache.org/r/51603/diff/
> 
> 
> Testing
> -------
> 
> Passing `--enable-libevent --enable-ssl` to `support/mesos-tidy.sh` fails before this
patch, and succeeds after.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message