mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 51603: Fixed remaining quoting issues.
Date Fri, 02 Sep 2016 15:17:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51603/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-4907
    https://issues.apache.org/jira/browse/MESOS-4907


Repository: mesos


Description
-------

`CONFIGURE_FLAGS` might be multiple arguments so a passed string
should always be exploded when used. Conversely, `SRCDIR` can only be
used as a single argument; we do know that it does not contain spaces,
but should quote it nevertheless for consistency.


Diffs
-----

  support/mesos-tidy/entrypoint.sh 78198d900556427091ab08f25b6df4fc9428dd93 

Diff: https://reviews.apache.org/r/51603/diff/


Testing
-------

Passing `--enable-libevent --enable-ssl` to `support/mesos-tidy.sh` fails before this patch,
and succeeds after.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message