mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 51358: Implemented recursive helper method findContainerDir for provisioner.
Date Fri, 02 Sep 2016 13:09:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51358/#review147654
-----------------------------------------------------------




src/slave/containerizer/mesos/provisioner/paths.cpp (line 111)
<https://reviews.apache.org/r/51358/#comment214871>

    kill this



src/slave/containerizer/mesos/provisioner/paths.cpp (lines 132 - 133)
<https://reviews.apache.org/r/51358/#comment214873>

    How about putting the `container directory path` into the error message?


- Guangya Liu


On 八月 29, 2016, 9:20 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51358/
> -----------------------------------------------------------
> 
> (Updated 八月 29, 2016, 9:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph Wu, and
Kevin Klues.
> 
> 
> Bugs: MESOS-6067
>     https://issues.apache.org/jira/browse/MESOS-6067
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented recursive helper method findContainerDir for provisioner.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/paths.hpp 9829d6b52c8547ae22297a5bc47852ce5a219e4c

>   src/slave/containerizer/mesos/provisioner/paths.cpp 86a45f30c22dc1e41f4779c0ce8c11d02dcc46bb

> 
> Diff: https://reviews.apache.org/r/51358/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message