mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 51476: Made the `TaskInfo` argument in `launchExecutor()` optional.
Date Fri, 02 Sep 2016 09:28:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51476/
-----------------------------------------------------------

(Updated Sept. 2, 2016, 9:28 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Added an explicit conditional check to not pass `taskInfo` for custom executors.


Bugs: MESOS-6076
    https://issues.apache.org/jira/browse/MESOS-6076


Repository: mesos


Description
-------

Launching a task group requires just the `ExecutorInfo`. We had
already refactored the containerizer `launch()` interface to make
`TaskInfo` as an optional. This change funnels it through.


Diffs (updated)
-----

  src/slave/slave.hpp 4add4c0180ea56039e0d5009bad4d9346128bde6 
  src/slave/slave.cpp 5d162d00a8a9a0e318c39bda93dd584f23c87987 

Diff: https://reviews.apache.org/r/51476/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message