mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 51594: Properly quoted string in shell script.
Date Fri, 02 Sep 2016 08:11:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51594/#review147637
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Sept. 2, 2016, 8:09 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51594/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2016, 8:09 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4907
>     https://issues.apache.org/jira/browse/MESOS-4907
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was intended to be formatted as code in markdown style, instead
> it was interpreted as a command to run. Use single quotes to prevent
> interpretion of the string.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy.sh 16d436381f4c3fdd716903e92e0e395de4335238 
> 
> Diff: https://reviews.apache.org/r/51594/diff/
> 
> 
> Testing
> -------
> 
> With an uncommitted change in the source tree, 
> 
> * before:
>         ./support/mesos-tidy.sh: line 33: mesos-tidy: command not found
>         Please commit or stash any changes before running .
> 
> * after:
>         Please commit or stash any changes before running `mesos-tidy`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message