mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51525: Added tooling to execute Mesos-specific clang-tidy checks.
Date Thu, 01 Sep 2016 12:37:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51525/#review147554
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51525]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Sept. 1, 2016, 10:49 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51525/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2016, 10:49 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4907
>     https://issues.apache.org/jira/browse/MESOS-4907
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commits adds tooling to both build and execute Mesos-specific
> clang-tidy checks. We use a docker container for the execution, and
> also provide a script to further streamline the tooling.
> 
> 
> Diffs
> -----
> 
>   support/mesos-tidy.sh PRE-CREATION 
>   support/mesos-tidy/Dockerfile PRE-CREATION 
>   support/mesos-tidy/README.md PRE-CREATION 
>   support/mesos-tidy/entrypoint.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51525/diff/
> 
> 
> Testing
> -------
> 
> The image used in `support/mesos-tidy.sh` is available on dockerhub, and running that
script does produce diagnostics.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message