mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 51566: Changed Master::_accept() to not pass invalid tasks to the allocator.
Date Thu, 01 Sep 2016 02:14:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51566/#review147527
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51566]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Aug. 31, 2016, 10:42 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51566/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos and Anindya Sinha.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> So in Allocator::updateAllocation() we can assume all tasks are valid.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 192b2ce5eb24deb6e843f2f1a8c915114614b268 
> 
> Diff: https://reviews.apache.org/r/51566/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message