mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 51378: Exposed `process::internal::defaultClone` to `process` namespace.
Date Thu, 01 Sep 2016 02:05:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51378/#review147525
-----------------------------------------------------------




3rdparty/libprocess/include/process/posix/subprocess.hpp (lines 55 - 68)
<https://reviews.apache.org/r/51378/#comment214713>

    Any reason you need to expose this internal method? Why not just write your own clone
function at the call sites? THis default clone sounds pretty straight forward to me. Copy
that to the call site is probably more readable.
    
    `process::defaultClone` just sounds like a very weird public interface.
    
    I'd suggest we revert this change.


- Jie Yu


On Aug. 28, 2016, 1:55 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51378/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert
Song, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-5961
>     https://issues.apache.org/jira/browse/MESOS-5961
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Exposed `process::internal::defaultClone` to `process` namespace.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp a871fe484905165eed093124687c4920f3968ccc

> 
> Diff: https://reviews.apache.org/r/51378/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/51379/
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message