From reviews-return-43942-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Aug 26 14:12:55 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 367C219575 for ; Fri, 26 Aug 2016 14:12:55 +0000 (UTC) Received: (qmail 94911 invoked by uid 500); 26 Aug 2016 14:12:55 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 94887 invoked by uid 500); 26 Aug 2016 14:12:55 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 94850 invoked by uid 99); 26 Aug 2016 14:12:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Aug 2016 14:12:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 93D582CF7F8; Fri, 26 Aug 2016 14:12:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0339758395750071009==" MIME-Version: 1.0 Subject: Re: Review Request 51069: Refactored `_commandHealthCheck` in health check. From: haosdent huang To: Timothy Chen , =?utf-8?q?Gast=C3=B3n_Kleiman?= , Benjamin Mahler , Jie Yu , Gilbert Song , Alexander Rukletsov Cc: Mesos ReviewBot , haosdent huang , mesos Date: Fri, 26 Aug 2016 14:12:52 -0000 Message-ID: <20160826141252.2090.51740@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51069/ X-Sender: haosdent huang References: <20160826125221.1118.23105@reviews.apache.org> In-Reply-To: <20160826125221.1118.23105@reviews.apache.org> Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============0339758395750071009== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51069/ ----------------------------------------------------------- (Updated Aug. 26, 2016, 2:12 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. Changes ------- Address @alexr's comments. Repository: mesos Description (updated) ------- * Removed blocking `Future::await` call. * Adjust the level of some logs. * Adjust style. * Change the interface of health check handlers to `Future` to make errors handling more easier. Diffs (updated) ----- src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 src/health-check/health_checker.cpp 5bdbd2ab45feecfab494bcacfbcc92c396f4f723 Diff: https://reviews.apache.org/r/51069/diff/ Testing ------- Thanks, haosdent huang --===============0339758395750071009==--