From reviews-return-43652-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 24 17:22:31 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 744391958E for ; Wed, 24 Aug 2016 17:22:31 +0000 (UTC) Received: (qmail 261 invoked by uid 500); 24 Aug 2016 17:22:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 231 invoked by uid 500); 24 Aug 2016 17:22:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 193 invoked by uid 99); 24 Aug 2016 17:22:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2016 17:22:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 247272CD7D6; Wed, 24 Aug 2016 17:22:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6920504410801548556==" MIME-Version: 1.0 Subject: Re: Review Request 51266: Unshared the mount namespace when launching mesos-containerizer. From: haosdent huang To: Timothy Chen , =?utf-8?q?Gast=C3=B3n_Kleiman?= , Benjamin Mahler , Jie Yu , Gilbert Song , Alexander Rukletsov Cc: haosdent huang , mesos Date: Wed, 24 Aug 2016 17:22:29 -0000 Message-ID: <20160824172229.2090.87869@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: haosdent huang X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51266/ X-Sender: haosdent huang References: <20160824164753.2089.54886@reviews.apache.org> In-Reply-To: <20160824164753.2089.54886@reviews.apache.org> Reply-To: haosdent huang X-ReviewRequest-Repository: mesos --===============6920504410801548556== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51266/ ----------------------------------------------------------- (Updated Aug. 24, 2016, 5:22 p.m.) Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gastón Kleiman, Gilbert Song, Jie Yu, and Timothy Chen. Changes ------- Rebase. Repository: mesos Description ------- When launching mesos-containerizer in the mesos-executor, we need to ensure mesos-executor unshare the mount namespace with mesos-containerizer. Otherwise, the mount and pivot_root operations in mesos-containerizer would affect the running context of mesos-executor. Diffs (updated) ----- src/launcher/posix/executor.cpp 43573cacee4e681d4327a7ed7c43b4ee263aa175 Diff: https://reviews.apache.org/r/51266/diff/ Testing ------- Thanks, haosdent huang --===============6920504410801548556==--