From reviews-return-43592-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Aug 24 01:17:57 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 906E419EA9 for ; Wed, 24 Aug 2016 01:17:57 +0000 (UTC) Received: (qmail 79088 invoked by uid 500); 24 Aug 2016 01:17:57 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 79060 invoked by uid 500); 24 Aug 2016 01:17:57 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 79039 invoked by uid 99); 24 Aug 2016 01:17:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2016 01:17:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D78C22CD454; Wed, 24 Aug 2016 01:17:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0356971539581272810==" MIME-Version: 1.0 Subject: Re: Review Request 51321: Added a test to ensure the master handles launching task groups. From: Guangya Liu To: Vinod Kone Cc: Benjamin Mahler , Guangya Liu , mesos Date: Wed, 24 Aug 2016 01:17:54 -0000 Message-ID: <20160824011754.2089.65305@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Guangya Liu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51321/ X-Sender: Guangya Liu References: <20160824004152.2089.88666@reviews.apache.org> In-Reply-To: <20160824004152.2089.88666@reviews.apache.org> Reply-To: Guangya Liu X-ReviewRequest-Repository: mesos --===============0356971539581272810== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On 八月 24, 2016, 12:41 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 548 > > > > > > ASSERT_EQ(runTaskGroupMessage->task_group(), 2); I think that we are always putting the `expected value` as the first parameter, so would expect the following: ``` ASSERT_EQ(2, runTaskGroupMessage->task_group().tasks().size()); ``` - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51321/#review146597 ----------------------------------------------------------- On 八月 23, 2016, 5:11 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51321/ > ----------------------------------------------------------- > > (Updated 八月 23, 2016, 5:11 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6045 > https://issues.apache.org/jira/browse/MESOS-6045 > > > Repository: mesos > > > Description > ------- > > For now this test ensures the message is sent to the agent > in the successful launch path. More tests will be added to > test the all-or-nothing paths (killed, invalid, unauthorized). > > > Diffs > ----- > > src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 > > Diff: https://reviews.apache.org/r/51321/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > > --===============0356971539581272810==--