From reviews-return-43585-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 23 23:31:13 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1F4E19A36 for ; Tue, 23 Aug 2016 23:31:13 +0000 (UTC) Received: (qmail 70101 invoked by uid 500); 23 Aug 2016 23:31:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 70074 invoked by uid 500); 23 Aug 2016 23:31:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 70052 invoked by uid 99); 23 Aug 2016 23:31:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Aug 2016 23:31:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8425E2CD3CE; Tue, 23 Aug 2016 23:31:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6557281741603672132==" MIME-Version: 1.0 Subject: Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs: WIP. From: Mesos ReviewBot To: Jie Yu , haosdent huang , Gilbert Song Cc: Zhitao Li , Mesos ReviewBot , mesos Date: Tue, 23 Aug 2016 23:31:11 -0000 Message-ID: <20160823233111.2089.97637@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos ReviewBot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51052/ X-Sender: Mesos ReviewBot References: <20160822222446.2090.97322@reviews.apache.org> In-Reply-To: <20160822222446.2090.97322@reviews.apache.org> Reply-To: Mesos ReviewBot X-ReviewRequest-Repository: mesos --===============6557281741603672132== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review146592 ----------------------------------------------------------- Patch looks great! Reviews applied: [51009, 51052] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 22, 2016, 10:24 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51052/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 10:24 p.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-2154 > https://issues.apache.org/jira/browse/MESOS-2154 > > > Repository: mesos > > > Description > ------- > > This fixes cpu quota for command executor (which runs outside > of the docker container) by ensuing --cpu-quota flag to docker > run. > > Note: we have to add the boolean variable to `Docker` class > because `Docker::run()` has reached the maximum argument length > GMOCK can support. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 > src/docker/executor.hpp 7b63d784d6b8685912598b77fb38cf6e70646ae3 > src/docker/executor.cpp 8d679cd33b6ddf3a5c11bb8c458a97b8809473ac > src/slave/containerizer/docker.cpp e447c58bd46ba080529e8f349347eccf5a54110a > src/tests/mesos.cpp f5034f9f8de7040182e10f51be125a87b29fdd24 > > Diff: https://reviews.apache.org/r/51052/diff/ > > > Testing > ------- > > I am now able to make docker containers launched through mesos-execute have a cpu quota. > > Also making sure `make check` still works on mac os for the linux only flag. > > > Thanks, > > Zhitao Li > > --===============6557281741603672132==--