From reviews-return-43225-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Aug 18 22:46:08 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19AFD19DF6 for ; Thu, 18 Aug 2016 22:46:08 +0000 (UTC) Received: (qmail 84058 invoked by uid 500); 18 Aug 2016 22:46:08 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 84030 invoked by uid 500); 18 Aug 2016 22:46:08 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 84010 invoked by uid 99); 18 Aug 2016 22:46:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2016 22:46:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B76F2CC7B5; Thu, 18 Aug 2016 22:46:06 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1614817261550695188==" MIME-Version: 1.0 Subject: Re: Review Request 49849: Implemented `CpuSubsystem`. From: Jie Yu To: Jie Yu , Zhengju Sha , Gilbert Song , Qian Zhang Cc: haosdent huang , mesos Date: Thu, 18 Aug 2016 22:46:06 -0000 Message-ID: <20160818224606.26606.40918@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49849/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20160818160935.25630.70270@reviews.apache.org> In-Reply-To: <20160818160935.25630.70270@reviews.apache.org> X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp X-ReviewBoard-Diff-For: src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp Reply-To: Jie Yu X-ReviewRequest-Repository: mesos --===============1614817261550695188== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/#review146135 ----------------------------------------------------------- Fix it, then Ship it! Made some adjustment while committing. Please take a look and adjust the following patches. Thanks! src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (lines 34 - 36) No need to prepend with leading underscore for these variables. src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 46) I meant to have a static `create` method for each subsystem. src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp (line 44) I'd hide this constructor. - Jie Yu On Aug. 18, 2016, 4:09 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49849/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2016, 4:09 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5042 > https://issues.apache.org/jira/browse/MESOS-5042 > > > Repository: mesos > > > Description > ------- > > Implemented `CpuSubsystem`. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 7e205a3eea4ad89faccf564bdb2ad0041fdee249 > src/slave/containerizer/mesos/isolators/cgroups/constants.hpp c45d88092f3fe497373dfeaa8346aef9126c7b8b > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 5f52a076a1fa3a21d886cb961ddeed5046a38d7c > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49849/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============1614817261550695188==--