From reviews-return-43035-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Aug 16 01:34:03 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2DBF6190E9 for ; Tue, 16 Aug 2016 01:34:03 +0000 (UTC) Received: (qmail 69147 invoked by uid 500); 16 Aug 2016 01:34:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 69116 invoked by uid 500); 16 Aug 2016 01:34:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 69089 invoked by uid 99); 16 Aug 2016 01:34:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Aug 2016 01:34:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BBB5A2CBD78; Tue, 16 Aug 2016 01:34:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3571182654946512193==" MIME-Version: 1.0 Subject: Review Request 51122: Fixed memory leak in agent signal handlers. From: Joseph Wu To: Benjamin Mahler , Artem Harutyunyan , Vinod Kone , Greg Mann Cc: Joseph Wu , mesos Date: Tue, 16 Aug 2016 01:34:01 -0000 Message-ID: <20160816013401.17019.38638@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51122/ X-Sender: Joseph Wu Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============3571182654946512193== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51122/ ----------------------------------------------------------- Review request for mesos, Benjamin Mahler, Greg Mann, Artem Harutyunyan, and Vinod Kone. Repository: mesos Description ------- This leak was introduced on purpose in: https://reviews.apache.org/r/34016/ When we run tests in repetition, each agent will create a new signal handler and leak the old one. We can either delete the old signal handler, or guard this function with a `Once`. Diffs ----- src/slave/posix_signalhandler.hpp 4a5411793e55f912c6e8ae72f9a8042d3a6195b5 Diff: https://reviews.apache.org/r/51122/diff/ Testing ------- make check (OSX) Found this leak via code inspection after valgrind. Thanks, Joseph Wu --===============3571182654946512193==--