From reviews-return-42999-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Aug 15 20:18:25 2016 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DDF69194B9 for ; Mon, 15 Aug 2016 20:18:24 +0000 (UTC) Received: (qmail 12555 invoked by uid 500); 15 Aug 2016 20:18:24 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 12522 invoked by uid 500); 15 Aug 2016 20:18:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 11920 invoked by uid 99); 15 Aug 2016 20:18:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Aug 2016 20:18:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E33F52CBC88; Mon, 15 Aug 2016 20:18:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0139380481047050829==" MIME-Version: 1.0 Subject: Re: Review Request 50857: Modified a scheduler test to run with SSL enabled. From: Greg Mann To: Joseph Wu , Vinod Kone Cc: Mesos ReviewBot , Greg Mann , mesos Date: Mon, 15 Aug 2016 20:18:22 -0000 Message-ID: <20160815201822.17020.7503@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50857/ X-Sender: Greg Mann References: <20160813071603.7516.70103@reviews.apache.org> In-Reply-To: <20160813071603.7516.70103@reviews.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============0139380481047050829== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/ ----------------------------------------------------------- (Updated Aug. 15, 2016, 8:18 p.m.) Review request for mesos, Joseph Wu and Vinod Kone. Bugs: MESOS-3753 https://issues.apache.org/jira/browse/MESOS-3753 Repository: mesos Description ------- This patch modifies the test `SchedulerTest.Teardown` to be parametrized by both `ContentType` and SSL configuration, and renames it to `SchedulerSSLTest.RunTaskAndTeardown`. This allows the test to verify the scheduler's behavior with SSL both enabled and disabled. Diffs (updated) ----- src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 Diff: https://reviews.apache.org/r/50857/diff/ Testing ------- This test is currently flaky in the SSL-enabled configurations and I've seen it produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try: `GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" bin/mesos-tests.sh` Thanks, Greg Mann --===============0139380481047050829==--